Modify date enrichment to allow dates like '1935/07, ca.'#1274
Open
barbarahui wants to merge 1 commit intomainfrom
Open
Modify date enrichment to allow dates like '1935/07, ca.'#1274barbarahui wants to merge 1 commit intomainfrom
barbarahui wants to merge 1 commit intomainfrom
Conversation
Collaborator
|
Oh geez. The date code is extremely complex. I'm worried about the implications of this change, especially since we don't really have any way to test it. Is it possible to make the change closer to the relevant data? Like, in the mapper potentially? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some records in collection 26935 with a date format we must not have encountered before:
1935/07, ca.,1881/05, ca.,1985/12, ca.. This PR allows for these dates to be enriched. I think the change I made is innocuous, but wow this code is complex!